Thread (11 messages) 11 messages, 4 authors, 2012-01-24

Re: [PATCH 1/3] net: fix socket memcg build with !CONFIG_NET

From: Glauber Costa <hidden>
Date: 2012-01-21 14:18:21
Also in: lkml, netdev

On 01/20/2012 11:14 PM, David Miller wrote:
From: Glauber Costa<redacted>
Date: Fri, 20 Jan 2012 18:57:14 +0400
quoted
There is still a build bug with the sock memcg code, that triggers
with !CONFIG_NET, that survived my series of randconfig builds.

Signed-off-by: Glauber Costa<redacted>
Reported-by: Randy Dunlap<rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
CC: Hiroyouki Kamezawa<redacted>
Why are you undoing the static branch optimization?  That was a one of
the things that made me agree to even putting this code in.

Find a way to fix this without removing the static branch.
Dave,

I am not removing the static branch. This is just a macro, that expands 
to the static branch when the options are in place, and to 0 if they are 
not.

if (0) { } is certainly be removed to the compiler, so the code is out
anyway.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help