Re: [PATCH 2/5] cgroup: remove redundant get/put of task struct
From: Tejun Heo <hidden>
Date: 2011-12-20 23:23:36
Also in:
lkml
Hello, On Tue, Dec 20, 2011 at 03:14:30PM -0800, Mandeep Singh Baines wrote:
quoted hunk ↗ jump to hunk
@@ -2287,14 +2280,12 @@ static int attach_task_by_pid(struct cgroup *cgrp, u64 pid, bool threadgroup) cgroup_unlock(); return -EACCES; } - get_task_struct(tsk); rcu_read_unlock();
This is before threadgroup is locked. What guarantees @tsk doesn't go away once rcu is unlocked? Thanks. -- tejun