[PATCH] cgroups: remove redundant get/put of css_set from css_set_check_fetched()
From: Mandeep Singh Baines <hidden>
Date: 2011-12-15 22:21:51
Also in:
lkml
Subsystem:
the rest · Maintainer:
Linus Torvalds
We already have a reference to all elements in newcg_list. Signed-off-by: Mandeep Singh Baines <redacted> Cc: Tejun Heo <redacted> Cc: Li Zefan <redacted> Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Paul Menage <redacted> --- kernel/cgroup.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index d9d5648..a7e00b9 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c@@ -1935,23 +1935,17 @@ static bool css_set_check_fetched(struct cgroup *cgrp, read_lock(&css_set_lock); newcg = find_existing_css_set(cg, cgrp, template); - if (newcg) - get_css_set(newcg); read_unlock(&css_set_lock); /* doesn't exist at all? */ if (!newcg) return false; /* see if it's already in the list */ - list_for_each_entry(cg_entry, newcg_list, links) { - if (cg_entry->cg == newcg) { - put_css_set(newcg); + list_for_each_entry(cg_entry, newcg_list, links) + if (cg_entry->cg == newcg) return true; - } - } /* not found */ - put_css_set(newcg); return false; }
--
1.7.3.1