On 12/11/2011 07:55 PM, KOSAKI Motohiro wrote:

quoted

-static int notify_on_release(const struct cgroup *cgrp)
+static inline int notify_on_release(const struct cgroup *cgrp)
   {
   	return test_bit(CGRP_NOTIFY_ON_RELEASE,&cgrp->flags);
   }

-static int clone_children(const struct cgroup *cgrp)
+static inline int clone_children(const struct cgroup *cgrp)
   {
   	return test_bit(CGRP_CLONE_CHILDREN,&cgrp->flags);
   }

Can you please tell us which compiler failed automatic inlining?
I suspect gcc is enough sane and we don't need this patch.

Of course we don't need, that's the very definition of a "nitpick".
This patch is directed towards the reader, not the compiler. Maintainers
are free to take it or not, although I believe being explicit is better.

--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html