Re: [Buildroot] [PATCH] package/gnuradio: bump version to 3.10.3.0
From: Thomas Petazzoni via buildroot <hidden>
Date: 2022-08-15 10:58:25
Hello, On Mon, 8 Aug 2022 10:09:10 +0200 Gwenhael Goavec-Merou [off-list ref] wrote:
From: Gwenhael Goavec-Merou <redacted> - remove all no more required patches - add dependency to SPDLOG - add pybind dependency where python is set Signed-off-by: Gwenhael Goavec-Merou <redacted>
Thanks for this version bump. A few questions below.
select BR2_PACKAGE_PYTHON_NUMPY # runtime + select BR2_PACKAGE_PYTHON_PYBIND # runtime
So here you're saying that python-numpy and python-pybind are runtime dependencies.
ifeq ($(BR2_PACKAGE_GNURADIO_PYTHON),y) -GNURADIO_DEPENDENCIES += python3 +GNURADIO_DEPENDENCIES += python3 python-numpy python-pybind \
But you have them as build-time dependencies here. Could you check this?
+ host-python-mako host-python-numpy host-python-packaging
Are these host-python-* really needed? Why would gnuradio needs numpy at build time? Or are they just here to satisfy some broken build system that verifies NumPy is installed on the build machine, even though really they are needed only on the target? Thanks! Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot