Re: [Buildroot] [PATCH v5 05/10] board: Add Sipeed MAIX-bit support

On Thu, 2021-12-30 at 21:27 +0100, Thomas Petazzoni wrote:

Hello Damien,

On Tue, 26 Oct 2021 16:17:23 +0900
Damien Le Moal [off-list ref] wrote:

quoted

Add two configuration files to support the dual-core RV64 Canaan K210
SoC based Sipeed MAIX-bit board.

You had lots of feedback from Peter Korsgaard on your Buildroot
defconfigs. Do you think you will have the chance to post an updated
version? I will mark patches 5/10 to 10/10 as Superseded. This means
that if you don't get back to us with an updated version, we will
forget about those patches.

My apologies about the delay. I have been swamped with the kernel and other
projects. I kept at this a little though, mainly trying to address the elf2flt
issue which seems to generate unworkable binaries for Peter, while it is always
working for me... Really no clue what is going on so I am a little stuck with
that. I will work on updates addressing all of Peter's comments and see how
that work.

Just two additional notes:

 - The readme files should be readme.txt (not README.md), as we don't
   use markdown for now in our readme files.

OK.

 - The readme.txt file for each defconfig should be added in the patch
   adding the defconfig

Hmm... It is the same procedure for all boards, only the defconfig name
differs. Hence I added this README file last with all board defconfigs
mentioned. I can add the README file with the first board and update it with
each patch adding a board ?

 - The DEVELOPERS file should be updated, in each patch, to add a
   reference to you as a maintainer for these defconfigs and board/
   files.

OK.

Thanks a lot!

Thomas

Happy new year to all !


-- 
Damien Le Moal
Western Digital Research

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot