Re: [Buildroot] [PATCH 1/1] package/watchdogd: new package

On 10/27/21 10:13 PM, Arnout Vandecappelle wrote:

On 10/10/2021 17:49, Joachim Wiberg wrote:

quoted

[snip]

 Applied to master, thanks, with changes specified below.

Awesome, thank you! :)

quoted

[snip]
+config BR2_PACKAGE_WATCHDOGD_TEST_SUITE
+    bool "Enable watchdogctl test cases"
+    default y

 This doesn't sound like something you'd want enabled by default, so I
removed the "default y".

Of course, sorry about that!  I was sure I had filtered out all of our
old cruft from the $DAYJOB packaging.

quoted

+config BR2_PACKAGE_WATCHDOGD_GENERIC_POLL
+    int "Generic script monitor poll interval (sec)"
+    default "300"
+    help
+      Poll interval for generic script monitor, in seconds.  A value
+      of zero (0) disables the monitor.
+
+      Default: 300 seconds

 We normally don't have such Default: entries in the help text. It's
kind of pointless IMHO.

Ack!  I'm still getting accustomed to the nice new kconfig build
system.  So shiny :)

[snip]

quoted

+define WATCHDOGD_INSTALL_INIT_SYSV
+    $(INSTALL) -D -m 0755 package/watchdogd/S01watchdogd \
+        $(TARGET_DIR)/etc/init.d/S01watchdogd
+endef
+
+define WATCHDOGD_INSTALL_INIT_SYSTEMD
+    $(INSTALL) -D -m 644 $(WATCHDOGD_PKGDIR)/watchdogd.service \

 WATCHDOGD_PKGDIR is package/watchdog. You want WATCHDOGD_SRCDIR here.

Love your attention to detail.  Much appreciated you took the time to
clean up my mess!

Best regards
 /Joachim