Re: [Buildroot] [PATCH v1 2/2] package/libcamera: add lc-compliance test application option
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
Date: 2021-10-23 20:35:37
Quoting Peter Seiderer (2021-10-22 20:07:02)
quoted hunk ↗ jump to hunk
- add lc-compliance test application option (and add proper dependencies on gtest and libevent) Signed-off-by: Peter Seiderer <redacted> --- package/libcamera/Config.in | 18 ++++++++++++++++++ package/libcamera/libcamera.mk | 7 +++++++ 2 files changed, 25 insertions(+)diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in index b7f0e5b05d..23a0040abf 100644 --- a/package/libcamera/Config.in +++ b/package/libcamera/Config.in@@ -72,6 +72,24 @@ config BR2_PACKAGE_LIBCAMERA_PIPELINE_VIMC help Pipeline for the vimc device. +config BR2_PACKAGE_LIBCAMERA_COMPLIANCE + bool "lc-compliance test application" + depends on BR2_USE_WCHAR # gtest + depends on BR2_TOOLCHAIN_HAS_THREADS # gtest + depends on BR2_INSTALL_LIBSTDCPP # gtest + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # gtest
I think we stipulate a minimum gcc 7 on libcamera support, but this is for gtest ... Other than that, this is better than simply disabling. Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
quoted hunk ↗ jump to hunk
+ depends on BR2_USE_MMU # gtest + select BR2_PACKAGE_GTEST + select BR2_PACKAGE_LIBEVENT + help + lc-compliance test application + +comment "lc-compliance test application needs a toolchain w/ C++, wchar, threads, gcc >= 4.9" + depends on BR2_USE_MMU + depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \ + !BR2_INSTALL_LIBSTDCPP || \ + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 + endif # BR2_PACKAGE_LIBCAMERA comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7"diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk index 8ab95fb42a..5a5f2800b9 100644 --- a/package/libcamera/libcamera.mk +++ b/package/libcamera/libcamera.mk@@ -61,6 +61,13 @@ LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_VIMC) += vimc LIBCAMERA_CONF_OPTS += -Dpipelines=$(subst $(space),$(comma),$(LIBCAMERA_PIPELINES-y)) +ifeq ($(BR2_PACKAGE_LIBCAMERA_COMPLIANCE),y) +LIBCAMERA_DEPENDENCIES += gtest libevent +LIBCAMERA_CONF_OPTS += -Dlc-compliance=enabled +else +LIBCAMERA_CONF_OPTS += -Dlc-compliance=disabled +endif + # gstreamer-video-1.0, gstreamer-allocators-1.0 ifeq ($(BR2_PACKAGE_GSTREAMER1)$(BR2_PACKAGE_GST1_PLUGINS_BASE),yy) LIBCAMERA_CONF_OPTS += -Dgstreamer=enabled-- 2.33.1
_______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot