Re: [Buildroot] [PATCH v3 10/16] Makefile: breaks hardlinks in global {TARGET, HOST}_DIR on per-package build
From: Yann E. MORIN <hidden>
Date: 2021-09-17 19:51:32
Hervé, All, On 2021-08-17 10:39 +0200, Herve Codina spake thusly:
quoted hunk ↗ jump to hunk
Without this patch, a make <pkg>_rebuild detects overwrites. Indeed, in target_finalize steps some modifications are done on installed files (ie strip or TARGET_FINALIZE_HOOKS for instance). In order to avoid these modifications seen from per-package {TARGET,HOST}_DIR and so been analyzed as some overwrites, global {TARGET,HOST}_DIR is built using a full copy of the involved per-package files instead of hardlinks. Signed-off-by: Herve Codina <herve.codina@bootlin.com> Reviewed-by: Yann E. MORIN <redacted> --- Changes v1 to v2: - Added 'Reviewed-by: Yann E. MORIN' Changes v2 to v2: None Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/Makefile b/Makefile index 32fad004fe..ccf2020565 100644 --- a/Makefile +++ b/Makefile@@ -734,7 +734,7 @@ ifeq ($(BR2_PER_PACKAGE_DIRECTORIES),y) define per-package-rsync-delta $(Q)mkdir -p $(3) $(foreach pkg,$(1),\ - $(Q)rsync -a --link-dest=$(PER_PACKAGE_DIR)/$(pkg)/$(strip $(2))/ \ + $(Q)rsync -a \
I was about to apply that one, because it does not look like it (semantically) depends on the previous patches, but of course it does not apply cleanly... I found it too dangerous to apply and tweak locally without further consideration. So it follows the fate of the rest of the series: marked Changes Requested. Regards, Yann E. MORIN.
--filter='merge $($(call UPPERCASE,$(pkg))_DIR)/$(strip $(4))' \ $(PER_PACKAGE_DIR)/$(pkg)/$(strip $(2))/ \ $(3)$(sep)) -- 2.31.1 _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
-- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@lists.buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot