Re: [Buildroot] [PATCH v6 for-next 2/2] utils/test-pkg: add gitlab-ci support

On 21/08/2021 15:46, Romain Naour wrote:
[snip]

+.test_pkg:
+    stage: build
+    before_script:

 The same is done in the rest of this file, so OK, but I was wondering: why is
this done in before_script and not in variables?

+        - OUTPUT_DIR=${CI_JOB_NAME}
+    script:
+        - echo "Configure Buildroot for ${OUTPUT_DIR}"
+        - make O=${OUTPUT_DIR} syncconfig
+        - make O=${OUTPUT_DIR} savedefconfig
+        - echo 'Build buildroot'
+        - *run_make
+    needs:
+        - pipeline: $PARENT_PIPELINE_ID
+          job: generate-gitlab-ci-yml
+    artifacts:
+        when: always
+        expire_in: 2 weeks
+        paths:
+            - build.log
+            - br-test-pkg/*/.config

 We could use ${OUTPUT_DIR}/.config here, I think. Well, if we used variables
rather than before_script :-)

 I've anyway committed it as is because this works.

 Regards,
 Arnout

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot