Re: [Buildroot] [PATCH 1/1] package/python-pymupdf: depend on python3
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Date: 2021-08-14 13:49:50
Hello Asaf, On Sat, 14 Aug 2021 09:04:39 +0300 Asaf Kahlon [off-list ref] wrote:
quoted
This dependency should have been propagated to the two Config.in comments in that file, so that they don't appear if Python3 is not used. I fixed that up and applied to master. Thanks!Hmm that's interesting... I agree it's needed but from a quick look I think we have packages which don't do that (for example - txtorcon. If the toolchain doesn't support C++, we will see the "comment" part under the python2 external modules menu although python3 is needed). Do I miss something or is it a real mistake?
Indeed, python-txtorcon/Config.in is also wrong. Imagine the user: he has python2 enabled, and see "python-XYZ needs a toolchain w/ C++", so he goes ahead and enables C++. Back to the Python menu.. the comment has disappeared, but there is still no option to enable python-XYZ because the option depends on Python 3.x. It would be very confusing, so we definitely want to hide the Config.in comment with a "depends on BR2_PACKAGE_PYTHON3" in this case. Thanks! Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot