[Buildroot] [PATCH 2/3] package/wpa_supplicant: Add options to disable more features.

On 13/02/2021 13:21, Arnout Vandecappelle wrote:

On 10/02/2021 19:50, Nicolas Cavallari wrote:
[snip]

quoted

+config BR2_PACKAGE_WPA_SUPPLICANT_CTRL_IFACE
+	bool "Enable the Unix-socket control interface"
+	help
+	  Enable support for the Unix-socket-based API.
+

  I'm surprised that the control interface makes that much of a difference...
AFAIK it's just a single file, no?

Yes, a single 11 KLOC file :)
And some ap commands are factored between wpasupplicant and hostapd, so 
you can add another KLOC if AP support is enabled. The increase is 
mostly multiplicative with the other options...

[snip]

quoted

+ifneq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIRED),y)
+WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_DRIVER_WIRED \

  This should be written as:

WPA_SUPPLICANT_CONFIG_DISABLE += \
	CONFIG_DRIVER_WIRED \

  The file contains both styles, but I think we prefer the one-option-per-line
style for new code.

Will send a new patch monday anyway, because 1/3 exposes build failures 
due to missing options dependencies