Thread (22 messages) 22 messages, 5 authors, 2020-04-06

[Buildroot] [PATCH 1/2] package/cog: add option for platform DRM.

flat view

From: Charles Turner <hidden>
Date: 2020-03-10 13:49:42

Hi Peter,

On Tue, 2020-03-10 at 13:36 +0100, Peter Seiderer wrote:
quoted
diff --git a/package/cog/cog.mk b/package/cog/cog.mk
index d0e5b79c38..0bbc684436 100644
--- a/package/cog/cog.mk
+++ b/package/cog/cog.mk
@@ -8,13 +8,17 @@ COG_VERSION = 0.4.0
 COG_SITE = https://wpewebkit.org/releases
 COG_SOURCE = cog-$(COG_VERSION).tar.xz
 COG_INSTALL_STAGING = YES
-COG_DEPENDENCIES = dbus wpewebkit wpebackend-fdo
+COG_DEPENDENCIES = dbus wayland wpewebkit wpebackend-fdo
New option, unconditionally added new dependency on wayland?
Perhaps I should place that in a separate patch. Cog does depend on
wayland with wpewebkit, which is why I reflex-added it to the deps.
It's already depended on from the wpewebkit dependency, but I didn't
like relying on a separate packages dependency list for this package,
especially when Cog can be build with webkitgtk instead, in which case
it would not need the wayland dep (although I wonder if anyone has
tested that in buildroot yet :-))

From this reasoning, I will remove this added dependency on wayland.
quoted
 COG_LICENSE = MIT
 COG_LICENSE_FILES = COPYING
 COG_CONF_OPTS = \
 	-DCOG_BUILD_PROGRAMS=ON \
 	-DCOG_PLATFORM_FDO=ON \
-	-DCOG_PLATFORM_DRM=OFF \
 	-DCOG_HOME_URI='$(call
qstrip,$(BR2_PACKAGE_COG_PROGRAMS_HOME_URI))'

+ifeq ($(BR2_PACKAGE_COG_PLATFORM_DRM),y)
+	COG_CONF_OPTS += -DCOG_PLATFORM_DRM=ON
+	COG_DEPENDENCIES += libdrm libinput
missing:

#else
	COG_CONF_OPTS += -DCOG_PLATFORM_DRM=OFF
This is default off in CMake, which is why I removed it from the .mk
file here.

B.R
	Charlie.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help