Thread (26 messages) 26 messages, 4 authors, 2020-02-16

[Buildroot] [PATCH v4 1/9] configs/qemu_ppc_mac99_defconfig: add usual comments for Kconfig symbols

From: Joel Stanley <joel@jms.id.au>
Date: 2020-02-10 02:32:46

On Sun, 9 Feb 2020 at 18:03, Romain Naour [off-list ref] wrote:
This defconfig was generated by savedefconfig but we usually
use a manually modified defconfig to add some comments for
Kconfig symbols.

No content change intended.

Signed-off-by: Romain Naour <redacted>
Cc: Joel Stanley <joel@jms.id.au>
I dislike this is as it means the file must be manually updated, but
if this is preferred then ok.

Acked-by: Joel Stanley <joel@jms.id.au>
quoted hunk ↗ jump to hunk
---
 configs/qemu_ppc_mac99_defconfig | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/configs/qemu_ppc_mac99_defconfig b/configs/qemu_ppc_mac99_defconfig
index 9a33c3d82c..4a7c7ce599 100644
--- a/configs/qemu_ppc_mac99_defconfig
+++ b/configs/qemu_ppc_mac99_defconfig
@@ -1,8 +1,14 @@
+# Architecture
 BR2_powerpc=y
 BR2_powerpc_7400=y
-BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
+
+# System
 BR2_SYSTEM_DHCP="eth0"
+
+# Linux headers same as kernel, a 5.2 series
 BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_2=y
+
+# Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.2.4"
@@ -10,6 +16,11 @@ BR2_LINUX_KERNEL_DEFCONFIG="pmac32"
 BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/qemu/ppc-mac99/linux.fragment"
 BR2_LINUX_KERNEL_VMLINUX=y
 BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+
+# Serial port config
+BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
+
+# Filesystem
 BR2_TARGET_ROOTFS_CPIO=y
 BR2_TARGET_ROOTFS_EXT2=y
 # BR2_TARGET_ROOTFS_TAR is not set
--
2.24.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help