On Fri, 6 Dec 2019 00:02:44 +0100
Arnout Vandecappelle [off-list ref] wrote:
quoted
So what this patch seems to imply is that in fact gcc 4.9 is not really
required by the spidermonkey code. If that's the case, then yes I
believe having the patch is probably nicer than having to propagate the
dependency.
As I understand it, spidermonkey *does* use C++14 features (hence the need for
target GCC 4.9+). However, it also builds host tools which need only C++11
features, but the test is applied to host and target compiler indiscriminately.
The patch doesn't make a correct distinction between host and target, it just
generally lowers the minimum C++ version.
Ah, that's not good indeed.
Now, given that they assume C++14 support is available, it's relatively likely
that they'll start using those features in future versions. At that point.
things will anyway break and we need this condition. So I'd say, byte the bullet
now and require hsot and target GCC >= 4.9.
Fair enough. We need to resurrect the patch then, because I changed its
state to Changes Requested yesterday.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com