[Buildroot] make source-check

From
Cristian Ionescu-Idbohrn <hidden>
Date
2007-07-15 12:41:03
Reply to
Bernhard Fischer, 2007-07-09
On Mon, 9 Jul 2007, Bernhard Fischer wrote:
On Mon, Jul 09, 2007 at 12:01:08PM +0200, Cristian Ionescu-Idbohrn wrote:
quoted
On Mon, 9 Jul 2007, Bernhard Fischer wrote:
quoted
But, wouldn't you agree that doing the same thing witout changing the
.config could be a much more elegant way to do it?
If you have a better impl than my quick-hack, i'm eager to see it, sure.
Looks like there might be another way: see info-node "6.10 Target-specific
Variable Values" in a recent manual.  What do you think of something like:
--- Makefile	(revision 19052)
+++ Makefile	(working copy)
@@ -222,11 +222,8 @@

 source: $(TARGETS_SOURCE) $(HOST_SOURCE)

-.config.check: dependencies
-	$(SED) '/BR2_WGET/s/\"$$/ --spider\"/g' .config
-	touch $@
-
-_source-check: .config.check
+_source-check: WGET += --spider
+_source-check:
 	$(MAKE) source
That is, the wget option '--spider' will be used _only_ by target
'_source-check' and the '.config' won't have to be edited behind one's
back.


-- 
Cristian
Thread (8 messages) 8 messages, 3 authors, last reply 2007-07-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help