Re: [Bridge] [PATCH net-next] bridge: Propagate NETDEV_NOTIFY_PEERS notifier
From: Nikolay Aleksandrov <hidden>
Date: 2021-01-26 16:39:23
Also in:
netdev
On 26/01/2021 06:09, Hangbin Liu wrote:
quoted hunk ↗ jump to hunk
After adding bridge as upper layer of bond/team, we usually clean up the IP address on bond/team and set it on bridge. When there is a failover, bond/team will not send gratuitous ARP since it has no IP address. Then the down layer(e.g. VM tap dev) of bridge will not able to receive this notification. Make bridge to be able to handle NETDEV_NOTIFY_PEERS notifier. Signed-off-by: Hangbin Liu <redacted> --- net/bridge/br.c | 1 + 1 file changed, 1 insertion(+)diff --git a/net/bridge/br.c b/net/bridge/br.c index ef743f94254d..b6a0921bb498 100644 --- a/net/bridge/br.c +++ b/net/bridge/br.c@@ -125,6 +125,7 @@ static int br_device_event(struct notifier_block *unused, unsigned long event, v /* Forbid underlying device to change its type. */ return NOTIFY_BAD; + case NETDEV_NOTIFY_PEERS: case NETDEV_RESEND_IGMP: /* Propagate to master device */ call_netdevice_notifiers(event, br->dev);
I'm not convinced this should be done by the bridge, setups usually have multiple ports which may have link change events and these events are unrelated, i.e. we shouldn't generate a gratuitous arp for all every time, there might be many different devices present. We have setups with hundreds of ports which are mixed types of devices. That seems inefficient, redundant and can potentially cause problems. Also it seems this was proposed few years back: https://lkml.org/lkml/2018/1/6/135 Thanks, Nik