On 06/20, Guenter Roeck wrote:

On Tue, Jun 11, 2024 at 01:21:52PM +0200, Jiri Olsa wrote:

quoted

Adding uretprobe syscall instead of trap to speed up return probe.

This patch results in:

Building loongarch:allmodconfig ... failed
--------------
Error log:
In file included from include/linux/uprobes.h:49,
                 from include/linux/mm_types.h:16,
                 from include/linux/mmzone.h:22,
                 from include/linux/gfp.h:7,
                 from include/linux/xarray.h:16,
                 from include/linux/list_lru.h:14,
                 from include/linux/fs.h:13,
                 from include/linux/highmem.h:5,
                 from kernel/events/uprobes.c:13:
kernel/events/uprobes.c: In function 'arch_uprobe_trampoline':
arch/loongarch/include/asm/uprobes.h:12:33: error: initializer element is not constant

should be fixed by https://lore.kernel.org/all/ZmyZgzqsowkGyqmH@krava/ (local)
in this thread.

but may be arch/loongarch should override __weak arch_uprobe_trampoline() ?

Oleg.