Re: [PATCH v2] bpf: Add missing map_get_next_key method to bloom filter map
From: Joanne Koong <hidden>
Date: 2021-12-29 17:22:35
On 12/29/21 3:20 AM, tcs.kernel@gmail.com wrote:
From: Haimin Zhang <redacted>
Without it, kernel crashes in map_get_next_key().
Fixes: 9330986c0300 ("bpf: Add bloom filter map implementation")
Reported-by: TCS Robot <redacted>
Signed-off-by: Haimin Zhang <redacted>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
---Thanks for fixing this. I'll take a look at the other bpf_map_ops and see if there are other missing ones. Acked-by: Joanne Koong <redacted>
quoted hunk ↗ jump to hunk
kernel/bpf/bloom_filter.c | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/kernel/bpf/bloom_filter.c b/kernel/bpf/bloom_filter.c index 277a05e9c984..fa34dc871995 100644 --- a/kernel/bpf/bloom_filter.c +++ b/kernel/bpf/bloom_filter.c@@ -82,6 +82,11 @@ static int bloom_map_delete_elem(struct bpf_map *map, void *value) return -EOPNOTSUPP; } +static int bloom_map_get_next_key(struct bpf_map *map, void *key, void *next_key) +{ + return -EOPNOTSUPP; +} + static struct bpf_map *bloom_map_alloc(union bpf_attr *attr) { u32 bitset_bytes, bitset_mask, nr_hash_funcs, nr_bits;@@ -192,6 +197,7 @@ const struct bpf_map_ops bloom_filter_map_ops = { .map_meta_equal = bpf_map_meta_equal, .map_alloc = bloom_map_alloc, .map_free = bloom_map_free, + .map_get_next_key = bloom_map_get_next_key, .map_push_elem = bloom_map_push_elem, .map_peek_elem = bloom_map_peek_elem, .map_pop_elem = bloom_map_pop_elem,