Re: [PATCH bpf-next v2 1/2] bpf: clean-up bpf_verifier_vlog() for BPF_LOG_KERNEL log level
From: Hou Tao <hidden>
Date: 2021-11-02 03:46:40
Also in:
netdev
Hi, On 11/2/2021 6:01 AM, Daniel Borkmann wrote:
On 10/29/21 3:53 PM, Hou Tao wrote:quoted
An extra newline will output for bpf_log() with BPF_LOG_KERNEL level as shown below: [ 52.095704] BPF:The function test_3 has 12 arguments. Too many. [ 52.095704] [ 52.096896] Error in parsing func ptr test_3 in struct bpf_dummy_ops if (log->level == BPF_LOG_KERNEL) { - pr_err("BPF:%s\n", log->kbuf); + bool newline = n > 0 && log->kbuf[n - 1] == '\n'; + + pr_err("BPF:%s%s", log->kbuf, newline ? "" : "\n");nit: Given you change this anyway, is there a reason not to go with "BPF: %s%s" instead?
My bad, and will do it in v3.