Re: [PATCH v3 02/16] objtool: Explicitly avoid self modifying code in... | bpf

[PATCH v3 00/16] x86: Rewrite the retpoline rewrite logic · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
[PATCH v3 07/16] x86/asm: Fixup odd GEN-for-each-reg.h usage · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
[PATCH v3 04/16] objtool,x86: Replace alternatives with .retpoline_sites · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
[PATCH v3 02/16] objtool: Explicitly avoid self modifying code in .altinstr_replacement · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
Re: [PATCH v3 02/16] objtool: Explicitly avoid self modifying code in .altinstr_replacement · Josh Poimboeuf <hidden> · 2021-10-28
[PATCH v3 10/16] x86/alternative: Implement .retpoline_sites support · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
Re: [PATCH v3 10/16] x86/alternative: Implement .retpoline_sites support · Borislav Petkov <bp@alien8.de> · 2021-10-27
Re: [PATCH v3 10/16] x86/alternative: Implement .retpoline_sites support · Peter Zijlstra <peterz@infradead.org> · 2021-10-27
[PATCH v3 14/16] x86,bugs: Unconditionally allow spectre_v2=retpoline,amd · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
[PATCH v3 03/16] objtool: Shrink struct instruction · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
[PATCH v3 12/16] x86/alternative: Try inline spectre_v2=retpoline,amd · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
[PATCH v3 09/16] x86/retpoline: Create a retpoline thunk array · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
[PATCH v3 01/16] objtool: Classify symbols · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
Re: [PATCH v3 01/16] objtool: Classify symbols · Josh Poimboeuf <hidden> · 2021-10-28
[PATCH v3 08/16] x86/retpoline: Move the retpoline thunk declarations to nospec-branch.h · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
[PATCH v3 15/16] bpf, x86: Simplify computing label offsets · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
[PATCH v3 16/16] bpf,x86: Respect X86_FEATURE_RETPOLINE* · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
[PATCH v3 13/16] x86/alternative: Add debug prints to apply_retpolines() · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
[PATCH v3 11/16] x86/alternative: Handle Jcc __x86_indirect_thunk_\reg · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
Re: [PATCH v3 11/16] x86/alternative: Handle Jcc __x86_indirect_thunk_\reg · Borislav Petkov <bp@alien8.de> · 2021-10-28
[PATCH v3 06/16] x86/asm: Fix register order · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
[PATCH v3 05/16] x86/retpoline: Remove unused replacement symbols · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
Re: [PATCH v3 00/16] x86: Rewrite the retpoline rewrite logic · Alexei Starovoitov <hidden> · 2021-10-26
Re: [PATCH v3 00/16] x86: Rewrite the retpoline rewrite logic · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
Re: [PATCH v3 00/16] x86: Rewrite the retpoline rewrite logic · Alexei Starovoitov <hidden> · 2021-10-26
Re: [PATCH v3 00/16] x86: Rewrite the retpoline rewrite logic · Peter Zijlstra <peterz@infradead.org> · 2021-10-26
Re: [PATCH v3 00/16] x86: Rewrite the retpoline rewrite logic · Alexei Starovoitov <hidden> · 2021-10-26
Re: [PATCH v3 00/16] x86: Rewrite the retpoline rewrite logic · Peter Zijlstra <peterz@infradead.org> · 2021-10-27
Re: [PATCH v3 00/16] x86: Rewrite the retpoline rewrite logic · Alexei Starovoitov <hidden> · 2021-10-27
Re: [PATCH v3 00/16] x86: Rewrite the retpoline rewrite logic · Josh Poimboeuf <hidden> · 2021-10-28
Re: [PATCH v3 00/16] x86: Rewrite the retpoline rewrite logic · Borislav Petkov <bp@alien8.de> · 2021-10-28
Re: [PATCH v3 00/16] x86: Rewrite the retpoline rewrite logic · Miroslav Benes <mbenes@suse.cz> · 2021-10-29

Re: [PATCH v3 02/16] objtool: Explicitly avoid self modifying code in .altinstr_replacement

From: Josh Poimboeuf <hidden>
Date: 2021-10-28 04:01:16
Also in: lkml

On Tue, Oct 26, 2021 at 02:01:34PM +0200, Peter Zijlstra wrote:

+	/*
+	 * Alternative replacement code is just template code which is
+	 * sometimes copied to the original instruction, For now, don't

s/,/./

+	 * annotate it. (In the future we might consider annotating the
+	 * original instruction if/when it ever makes sense to do so.).

s/\.$//

+	 */

-- 
Josh

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help