On Mon, Sep 20, 2021 at 10:41 PM Dave Marchevsky [off-list ref] wrote:

On 9/20/21 7:43 PM, Andrii Nakryiko wrote:

quoted

Normalize all the other non-conforming SEC() usages across all
selftests. This is in preparation for libbpf to start to enforce
stricter SEC() rules in libbpf 1.0 mode.

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
---
 .../selftests/bpf/prog_tests/flow_dissector.c |  4 +--
 .../selftests/bpf/prog_tests/sockopt_multi.c  | 30 +++++++++----------
 tools/testing/selftests/bpf/progs/bpf_flow.c  |  3 +-
 .../bpf/progs/cg_storage_multi_isolated.c     |  4 +--
 .../bpf/progs/cg_storage_multi_shared.c       |  4 +--
 .../selftests/bpf/progs/sockopt_multi.c       |  5 ++--
 .../selftests/bpf/progs/test_cgroup_link.c    |  4 +--
 .../bpf/progs/test_misc_tcp_hdr_options.c     |  2 +-
 .../selftests/bpf/progs/test_sk_lookup.c      |  6 ++--
 .../selftests/bpf/progs/test_sockmap_listen.c |  2 +-
 .../progs/test_sockmap_skb_verdict_attach.c   |  2 +-
 .../bpf/progs/test_tcp_check_syncookie_kern.c |  2 +-
 .../bpf/progs/test_tcp_hdr_options.c          |  2 +-
 .../selftests/bpf/test_tcp_check_syncookie.sh |  2 +-

Ran test_tcp_check_syncookie.sh as CI suite doesn't - works.

Thanks for the due diligence!

checkpatch has some line length complaints, otherwise LGTM

Keep in mind that checkpatch is not the absolute authority. I think it
also didn't get the memo about the 100 character line limit :) But
generally yes, we should try to keep it more or less happy.

Acked-by: Dave Marchevsky <redacted>