Re: [PATCH] bpf: Fix off-by-one in tail call count limiting

[RFC PATCH 00/14] bpf/tests: Extend the eBPF test suite · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-26
[RFC PATCH 01/14] bpf/tests: add BPF_JMP32 test cases · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-26
[RFC PATCH 02/14] bpf/tests: add BPF_MOV tests for zero and sign extension · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-26
[RFC PATCH 03/14] bpf/tests: fix typos in test case descriptions · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-26
[RFC PATCH 04/14] bpf/tests: add more tests of ALU32 and ALU64 bitwise operations · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-26
[RFC PATCH 07/14] bpf/tests: add more ALU64 BPF_MUL tests · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-26
[RFC PATCH 05/14] bpf/tests: add more ALU32 tests for BPF_LSH/RSH/ARSH · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-26
[RFC PATCH 06/14] bpf/tests: add more BPF_LSH/RSH/ARSH tests for ALU64 · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-26
[RFC PATCH 08/14] bpf/tests: add tests for ALU operations implemented with function calls · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-26
[RFC PATCH 09/14] bpf/tests: add word-order tests for load/store of double words · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-26
[RFC PATCH 10/14] bpf/tests: add branch conversion JIT test · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-26
[RFC PATCH 11/14] bpf/tests: add test for 32-bit context pointer argument passing · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-26
[RFC PATCH 12/14] bpf/tests: add tests for atomic operations · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-26
[RFC PATCH 13/14] bpf/tests: add tests for BPF_CMPXCHG · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-26
[RFC PATCH 14/14] bpf/tests: add tail call test suite · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-26
Re: [RFC PATCH 00/14] bpf/tests: Extend the eBPF test suite · Andrii Nakryiko <hidden> · 2021-07-26
Re: [RFC PATCH 00/14] bpf/tests: Extend the eBPF test suite · Daniel Borkmann <daniel@iogearbox.net> · 2021-07-28
Re: [RFC PATCH 00/14] bpf/tests: Extend the eBPF test suite · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-28
[PATCH] bpf: Fix off-by-one in tail call count limiting · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-28
Re: [PATCH] bpf: Fix off-by-one in tail call count limiting · Yonghong Song <hidden> · 2021-07-28
Re: [PATCH] bpf: Fix off-by-one in tail call count limiting · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-07-29
Re: [PATCH] bpf: Fix off-by-one in tail call count limiting · Andrii Nakryiko <hidden> · 2021-07-29
Re: [PATCH] bpf: Fix off-by-one in tail call count limiting · Andrii Nakryiko <hidden> · 2021-07-29
Re: [PATCH] bpf: Fix off-by-one in tail call count limiting · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-08-01
Re: [PATCH] bpf: Fix off-by-one in tail call count limiting · Andrii Nakryiko <hidden> · 2021-08-02
Re: [PATCH] bpf: Fix off-by-one in tail call count limiting · Johan Almbladh <johan.almbladh@anyfinetworks.com> · 2021-08-05
Re: [PATCH] bpf: Fix off-by-one in tail call count limiting · Andrii Nakryiko <hidden> · 2021-08-05

From: Johan Almbladh <johan.almbladh@anyfinetworks.com>
Date: 2021-07-29 21:38:04
Also in: netdev

On Wed, Jul 28, 2021 at 9:13 PM Yonghong Song [off-list ref] wrote:

I also checked arm/arm64 jit. I saw the following comments:

         /* if (tail_call_cnt > MAX_TAIL_CALL_CNT)
          *      goto out;
          * tail_call_cnt++;
          */

Maybe we have this MAX_TAIL_CALL_CNT + 1 issue
for arm/arm64 jit?

That wouldn't be unreasonable. I don't have an arm or arm64 setup
available right now, but I can try to test it in qemu.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help