Re: [PATCH 4/4] drivers: net: mediatek: initial implementation of ccmni
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-06-23 17:25:19
Also in:
linux-arm-kernel, linux-doc, linux-mediatek, lkml, netdev
On Wed, Jun 23, 2021 at 07:34:52PM +0800, Rocco Yue wrote:
+EXPORT_SYMBOL(ccmni_rx_push);
Why are you exporting symbols that are not used by anyone in this patch series? That doesn't feel right. Who needs this?
+EXPORT_SYMBOL(ccmni_hif_hook);
Same with this, who calls this?
quoted hunk ↗ jump to hunk
+++ b/drivers/net/ethernet/mediatek/ccmni/ccmni.h
Why do you have a .h file for a single .c file? that shouldn't be needed. thanks, greg k-h