On 5/11/21 4:34 PM, Andrii Nakryiko wrote:

quoted

+       bpf_gen__emit(gen, BPF_JMP_IMM(BPF_JSGE, BPF_REG_7, 0, 1));
+       bpf_gen__emit(gen, BPF_JMP_IMM(BPF_JA, 0, 0,
+                                      -(gen->insn_cur - gen->insn_start - gen->cleanup_label) / 8 - 1));

Just curious, why not a single BPF_JSLT straight to the cleanup label?

ohh. I still didn't fix JA. I kept thinking to make it use imm32 to
address long standing issue with large programs. It was on my mind
for so long now that it became false reality :(
So above I did to avoid doing simm16 check. That's what llvm
will eventually generate. Once JA supports imm32, of course.
Thanks for asking. Will fix.