Thread (35 messages) 35 messages, 5 authors, 2021-04-06

Re: [Patch bpf-next v8 11/16] udp: implement ->read_sock() for sockmap

From: Alexei Starovoitov <hidden>
Date: 2021-04-03 06:45:37
Also in: netdev

On Fri, Apr 2, 2021 at 10:12 PM Cong Wang [off-list ref] wrote:
On Wed, Mar 31, 2021 at 11:01 PM John Fastabend
[off-list ref] wrote:
quoted
This 'else if' is always true if above is false right? Would be
impler and clearer IMO as,

               if (used <= 0) {
                        if (!copied)
                                copied = used;
                        break;
               }
               copied += used;

I don't see anyway for used to be great than  skb->len.
Yes, slightly better. Please feel free to submit a patch by yourself,
like always your patches are welcome.
Please submit a follow up patch as John requested
or I'm reverting your set.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help