Thread (22 messages) 22 messages, 3 authors, 2021-02-26

RE: [PATCH v6 bpf-next 3/9] libbpf: Add BTF_KIND_FLOAT support

From: John Fastabend <john.fastabend@gmail.com>
Date: 2021-02-26 01:58:25

Ilya Leoshkevich wrote:
The logic follows that of BTF_KIND_INT most of the time. Sanitization
replaces BTF_KIND_FLOATs with equally-sized empty BTF_KIND_STRUCTs on
older kernels, for example, the following:

    [4] FLOAT 'float' size=4

becomes the following:

    [4] STRUCT '(anon)' size=4 vlen=0

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Andrii Nakryiko <andrii@kernel.org>
---
If you do another rev it might be nice to note that with latest
llvm, latest libbpf, and this patch that older kernels (that were
failing with the float errors) will now start working correctly. I
assume for the this case the sanitize logic will just fix up the BTF
and everything will work as expected for the most part.

.John
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help