Thread (2 messages) 2 messages, 2 authors, 2012-12-15

[B.A.T.M.A.N.] [PATCH] batctl: indicate successful termination when -h is used

From: Moritz Warning <hidden>
Date: 2012-12-05 08:40:10
Subsystem: the rest · Maintainer: Linus Torvalds

The return value of batctl -h indicates failure while
it should indicate a successful execution.


Signed-off-by: Moritz Warning <redacted>
---
From: Moritz Warning <redacted>
Subject: [PATCH] batctl: change return value to indicate successful
 termination when -h is used

---
 main.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/main.c b/main.c
index 0a979bd..ea83bbf 100644
--- a/main.c
+++ b/main.c
@@ -114,8 +114,10 @@ int main(int argc, char **argv)
 		goto err;
 	}
 
-	if (strcmp(argv[1], "-h") == 0)
-		goto err;
+	if (strcmp(argv[1], "-h") == 0) {
+		print_usage();
+		exit(EXIT_SUCCESS);
+	}
 
 	if (strcmp(argv[1], "-v") == 0) {
 		printf("batctl %s [batman-adv: ", SOURCE_VERSION);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help