Thread (7 messages) 7 messages, 4 authors, 2012-09-23

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix change mac address of soft iface.

flat view

From: Sven Eckelmann <sven@narfation.org>
Date: 2012-09-18 14:55:32

On Tuesday 18 September 2012 16:41:58 Def wrote:
 Into function interface_set_mac_addr, the function tt_local_add
 was invoked before updating dev->dev_addr. The new MAC
 addresse was not tagged as NoPurge.
Please don't add extra whitespaces before your commit message.

Your Signed-off-by: is missing.

[...]
quoted hunk ↗ jump to hunk
-
-	memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
+	
Please don't add trailing whitespaces.

I have no idea whether this works... *looks at Antonio*. But thanks for
bringing this up in the issue tracker and sending this first version of the
patch.

The problems mentioned here can be found using
checkpatch/cppcheck/sparse/smatch [1]. We need to drop this patch due to these
problems because the next authorities (David S. Miller/Linus Torvalds/...)
would not be happy when we forward them this version of the patch.

Kind regards,
	Sven

[1] http://www.open-mesh.org/projects/open-mesh/wiki/Contribute#Submitting-patches

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help