Re: [B.A.T.M.A.N.] [RFC 1/3] batman-adv: bandwidth meter implementation
flat view
From: Sven Eckelmann <sven@narfation.org>
Date: 2012-08-13 09:14:21
On Thursday 09 August 2012 14:15:24 Edo Monticelli wrote: [...]
quoted hunk ↗ jump to hunk
+dst_unreach: + /* TODO not in .h + icmp_to_send->msg_type = DESTINATION_UNREACHABLE; + batadv_socket_add_packet(socket_client, icmp_to_send, packet_len); + */
[...]
+ goto out; /* TODO send an ack! */
[...]
+ goto out; /* TODO ?? */
[...]
quoted hunk ↗ jump to hunk
+ /* TODO redefine BW_PACKET_LEN */ + skb_reserve(skb, ETH_HLEN); + icmp_to_send = (struct batadv_icmp_packet *) + skb_put(skb, bw_packet_len);
[...]
quoted hunk ↗ jump to hunk
+ /* TODO notify batctl */ + spin_unlock_bh(&bat_priv->bw_list_lock); + batadv_dbg(BATADV_DBG_BATMAN, bat_priv, + "Meter: trying to interrupt an already over connection\n"); + return; + }
[...]
quoted hunk ↗ jump to hunk
+ /* TODO notify batctl */ + spin_unlock_bh(&bat_priv->bw_list_lock); + batadv_dbg(BATADV_DBG_BATMAN, bat_priv, + "Meter: test to or from the same node already ongoing,
aborting\n");
+ goto out; + }
Mh, Looks like some open tasks... ;) Can you also convert (and of course add) the documentation of all new functions/structures to KernelDoc style. Example templates can be found at http://www.open-mesh.org/projects/batman-adv/wiki/KernelDoc Kind regards, Sven
Attachments
- signature.asc [application/pgp-signature] 836 bytes