Thread (3 messages) 3 messages, 3 authors, 2021-07-18

Re: [PATCH] habv4: habv4_get_status(): do not print HAB error event in case of known RNG self test failure

From: Sascha Hauer <hidden>
Date: 2021-07-18 05:10:29

On Fri, Jul 16, 2021 at 02:21:10PM +0200, Marc Kleine-Budde wrote:
In commit

| 655e085e3a22 ("crypto: caam - Always do rng selftest")

the kconfig option CONFIG_CRYPTO_DEV_FSL_CAAM_RNG_SELF_TEST was
removed, which resulted in the pr_debug() never being executed. Remove
the IS_ENABLED() to restore the original behavior, i.e. to not print
the HAB error Event if it is the known RNG self-test failure.

Fixes: 655e085e3a22 ("crypto: caam - Always do rng selftest")
Reported-by: Roland Hieber <redacted>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 drivers/hab/habv4.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks

Sascha
quoted hunk ↗ jump to hunk
diff --git a/drivers/hab/habv4.c b/drivers/hab/habv4.c
index c2acb81369d8..d58768fa5481 100644
--- a/drivers/hab/habv4.c
+++ b/drivers/hab/habv4.c
@@ -553,8 +553,7 @@ static int habv4_get_status(const struct habv4_rvt *rvt)
 			break;
 
 		/* suppress RNG self-test fail events if they can be handled in software */
-		if (IS_ENABLED(CONFIG_CRYPTO_DEV_FSL_CAAM_RNG_SELF_TEST) &&
-		    is_known_rng_fail_event(data, len)) {
+		if (is_known_rng_fail_event(data, len)) {
 			pr_debug("RNG self-test failure detected, will run software self-test\n");
 		} else {
 			pr_err("-------- HAB Event %d --------\n", i);
-- 
2.30.2



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help