Re: [PATCH 1/4] common: boot: don't return too early in bootscript dryrun
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
Date: 2021-06-14 08:52:26
Hi, On 14.06.21 00:26, Marc Reilly wrote:
A dryrun boot will now run the boot script and a then a dryrun of the bootm.
This would change behavior for boot scripts that directly boot instead of setting up variables for bootm to use, but I think that's acceptable, Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
quoted hunk ↗ jump to hunk
Signed-off-by: Marc Reilly <redacted> --- common/boot.c | 1 - 1 file changed, 1 deletion(-)diff --git a/common/boot.c b/common/boot.c index 07b67734d..183e6bb43 100644 --- a/common/boot.c +++ b/common/boot.c@@ -77,7 +77,6 @@ static int bootscript_boot(struct bootentry *entry, int verbose, int dryrun) if (dryrun) { printf("Would run %s\n", bs->scriptpath); - return 0;
Maybe change message to reflect the new reality? s/Would run/Running/
}
globalvar_add_simple("linux.bootargs.dyn.ip", NULL);-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox