Thread (2 messages) 2 messages, 2 authors, 2017-09-20

[PATCH v1] net: ag71xx: disable eth interface on barebox shutdown

From: Oleksij Rempel <hidden>
Date: 2017-09-18 16:42:29
Subsystem: networking drivers, the rest · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

If not disable, DMA RX engine will keep to write in to allocated
memory area. As soon as some code or data of target OS will be placed to
this area it will be overwritten by incoming network package.

Signed-off-by: Oleksij Rempel <redacted>
---
 drivers/net/ag71xx.c | 9 +++++++++
 1 file changed, 9 insertions(+)
diff --git a/drivers/net/ag71xx.c b/drivers/net/ag71xx.c
index 54f0bd9aa..1cec26360 100644
--- a/drivers/net/ag71xx.c
+++ b/drivers/net/ag71xx.c
@@ -578,6 +578,7 @@ static int ag71xx_probe(struct device_d *dev)
 	priv = xzalloc(sizeof(struct ag71xx));
 	edev = &priv->netdev;
 	miibus = &priv->miibus;
+	dev->priv = edev;
 	edev->priv = priv;
 
 	edev->init = ag71xx_ether_init;
@@ -659,6 +660,13 @@ static int ag71xx_probe(struct device_d *dev)
 	return 0;
 }
 
+static void ag71xx_remove(struct device_d *dev)
+{
+	struct eth_device *edev = dev->priv;
+
+	ag71xx_ether_halt(edev);
+}
+
 static __maybe_unused struct of_device_id ag71xx_dt_ids[] = {
 	{ .compatible = "qca,ar9331-ge0", .data = &ag71xx_cfg_ar9331_ge0, },
 	{ .compatible = "qca,ar9344-gmac0", .data = &ag71xx_cfg_ar9344_gmac0, },
@@ -668,6 +676,7 @@ static __maybe_unused struct of_device_id ag71xx_dt_ids[] = {
 static struct driver_d ag71xx_driver = {
 	.name	= "ag71xx-gmac",
 	.probe		= ag71xx_probe,
+	.remove		= ag71xx_remove,
 	.of_compatible = DRV_OF_COMPAT(ag71xx_dt_ids),
 };
 device_platform_driver(ag71xx_driver);
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help