Re: [PATCH 06/13] drivers/net: add driver for the EMAC device found in some TI SoCs

On 08:59 Tue 21 Aug     , Jan Luebbe wrote:

On Mon, Aug 20, 2012 at 04:47:00PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:

quoted

On 16:20 Mon 20 Aug     , Jan Luebbe wrote:

quoted

+	/* EMAC Addresses */
+	emac_regs	*adap_emac; /* = (emac_regs *)EMAC_BASE_ADDR; */
+	ewrap_regs	*adap_ewrap; /* = (ewrap_regs *)EMAC_WRAPPER_BASE_ADDR; */
+	mdio_regs	*adap_mdio; /* = (mdio_regs *)EMAC_MDIO_BASE_ADDR; */

please use linux and not the struct for regs

The structs are only used for addresses, all accesses use readl/writel.

use offset not struct stuff wish are a meessup to maintain

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox