Thread (4 messages) 4 messages, 3 authors, 2011-11-24

[PATCH] readkey: force return from while true

From: Jan Weitzel <hidden>
Date: 2011-11-22 12:32:38
Subsystem: library code, the rest · Maintainers: Andrew Morton, Linus Torvalds

If read_key is feeded by STRG + KEY_LEFT you run into the while(1)
loop and corrupt memory through esc array.
Force return if index gets too high.

Signed-off-by: Jan Weitzel <redacted>
---
 lib/readkey.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/lib/readkey.c b/lib/readkey.c
index a42d1cb..895db82 100644
--- a/lib/readkey.c
+++ b/lib/readkey.c
@@ -67,6 +67,8 @@ int read_key(void)
 				esc[i] = getc();
 				if (esc[i++] == '~')
 					break;
+				if (i == 5)
+					return -1;
 			}
 		}
 		esc[i] = 0;
-- 
1.7.0.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help