# \[PATCH\] vdpa: Consider device id larger than 31 - Subsystems: VIRTIO CORE, THE REST - Maintainers: "Michael S. Tsirkin", Jason Wang, Eugenio Pérez, Linus Torvalds - List: virtualization - 2 messages, 2 authors - Page: https://ratatoskr.run/virtualization/2021/11/1586830/t ## \[PATCH\] vdpa: Consider device id larger than 31 - From: Parav Pandit \ - Date: 2021-11-25 18:11:47 - Message: https://ratatoskr.run/virtualization/2021/11/1586830.md ```text virtio device id value can be more than 31. Hence, use BIT_ULL in assignment. Fixes: 33b347503f01 ("vdpa: Define vdpa mgmt device, ops and a netlink interface") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Parav Pandit --- drivers/vdpa/vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c index 7332a74a4b00..e91c71aeeddf 100644 --- a/drivers/vdpa/vdpa.c +++ b/drivers/vdpa/vdpa.c @@ -404,7 +404,7 @@ static int vdpa_mgmtdev_fill(const struct vdpa_mgmt_dev *mdev, struct sk_buff *m goto msg_err; while (mdev->id_table[i].device) { - supported_classes |= BIT(mdev->id_table[i].device); + supported_classes |= BIT_ULL(mdev->id_table[i].device); i++; } -- 2.26.2 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ``` ## Re: \[PATCH\] vdpa: Consider device id larger than 31 - From: Jason Wang \ - Date: 2021-11-26 02:52:00 - Message: https://ratatoskr.run/virtualization/2021/11/1587238.md ```text On Fri, Nov 26, 2021 at 2:09 AM Parav Pandit [ref] wrote: > > virtio device id value can be more than 31. Hence, use BIT_ULL in > assignment. > > Fixes: 33b347503f01 ("vdpa: Define vdpa mgmt device, ops and a netlink interface") > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Parav Pandit Acked-by: Jason Wang > --- > drivers/vdpa/vdpa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c > index 7332a74a4b00..e91c71aeeddf 100644 > --- a/drivers/vdpa/vdpa.c > +++ b/drivers/vdpa/vdpa.c > @@ -404,7 +404,7 @@ static int vdpa_mgmtdev_fill(const struct vdpa_mgmt_dev *mdev, struct sk_buff *m > goto msg_err; > > while (mdev->id_table[i].device) { > - supported_classes |= BIT(mdev->id_table[i].device); > + supported_classes |= BIT_ULL(mdev->id_table[i].device); > i++; > } > > -- > 2.26.2 > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ```