# Re: \[PATCH v2 1/6\] driver core: Move the "authorized" attribute from USB/Thunderbolt to core

- From: Dan Williams \<hidden\>
- Date: 2021-09-30 19:05:02 
- List: virtualization
- Page: https://ratatoskr.run/virtualization/2021/09/1527475
- Thread: https://ratatoskr.run/linux-pci/2021/09/1526447/t.md

```text
On Thu, Sep 30, 2021 at 11:25 AM Yehezkel Bernat [ref] wrote:
>
> On Thu, Sep 30, 2021 at 6:28 PM Dan Williams [ref] wrote:
> >
> > On Thu, Sep 30, 2021 at 4:20 AM Yehezkel Bernat [ref] wrote:
> > >
> > > On Thu, Sep 30, 2021 at 4:05 AM Kuppuswamy Sathyanarayanan
> > > [ref] wrote:
> > > >
> > > > no functional
> > > > changes other than value 2 being not visible to the user.
> > > >
> > >
> > > Are we sure we don't break any user-facing tool with it? Tools might use this to
> > > "remember" how the device was authorized this time.
> >
> > That's why it was highlighted in the changelog. Hopefully a
> > Thunderbolt developer can confirm if it is a non-issue.
> > Documentation/ABI/testing/sysfs-bus-thunderbolt does not seem to
> > answer this question about whether authorized_show and
> > authorized_store need to be symmetric.
>
> Apparently, Bolt does read it [1] and cares about it [2].

Ah, thank you!

Yeah, looks like the conversion to bool was indeed too hopeful.

>
> [1] https://gitlab.freedesktop.org/bolt/bolt/-/blob/130e09d1c7ff02c09e4ad1c9c36e9940b68e58d8/boltd/bolt-sysfs.c#L511
> [2] https://gitlab.freedesktop.org/bolt/bolt/-/blob/130e09d1c7ff02c09e4ad1c9c36e9940b68e58d8/boltd/bolt-device.c#L639
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
```