# Re: \[PATCH v4 11/15\] pci: Add pci\_iomap\_shared{,\_range}

- From: Andi Kleen \<hidden\>
- Date: 2021-09-24 22:43:50 
- List: virtualization
- Page: https://ratatoskr.run/virtualization/2021/09/1521396
- Thread: https://ratatoskr.run/linux-pci/2021/08/1468282/t.md

```text

>> Hmm, yes that's true. I guess we can make it default to opt-in for
>> pci_iomap.
>>
>> It only really matters for device less ioremaps.
> OK. And same thing for other things with device, such as
> devm_platform_ioremap_resource.
> If we agree on all that, this will basically remove virtio
> changes from the picture ;)

Hi we revisited this now. One problem with removing the ioremap opt-in is that it's still possible for drivers to get at devices without going through probe. For example they can walk the PCI device list. Some drivers do that for various reasons. So if we remove the opt-in we would need to audit and possibly fix all that, which would be potentially a lot of churn. That's why I think it's better to keep the opt-in.


-Andi


_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
```