Re: [PATCH v11 01/12] iova: Export alloc_iova_fast() and free_iova_fast()

2 messages, 2 authors, 2021-08-25 · open the first message on its own page

Re: [PATCH v11 01/12] iova: Export alloc_iova_fast() and free_iova_fast()

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2021-08-24 18:08:43

On Wed, Aug 18, 2021 at 08:06:31PM +0800, Xie Yongji wrote:
Export alloc_iova_fast() and free_iova_fast() so that
some modules can make use of the per-CPU cache to get
rid of rbtree spinlock in alloc_iova() and free_iova()
during IOVA allocation.

Signed-off-by: Xie Yongji <redacted>

This needs ack from iommu maintainers. Guys?
quoted hunk
---
 drivers/iommu/iova.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c
index b6cf5f16123b..3941ed6bb99b 100644
--- a/drivers/iommu/iova.c
+++ b/drivers/iommu/iova.c
@@ -521,6 +521,7 @@ alloc_iova_fast(struct iova_domain *iovad, unsigned long size,
 
 	return new_iova->pfn_lo;
 }
+EXPORT_SYMBOL_GPL(alloc_iova_fast);
 
 /**
  * free_iova_fast - free iova pfn range into rcache
@@ -538,6 +539,7 @@ free_iova_fast(struct iova_domain *iovad, unsigned long pfn, unsigned long size)
 
 	free_iova(iovad, pfn);
 }
+EXPORT_SYMBOL_GPL(free_iova_fast);
 
 #define fq_ring_for_each(i, fq) \
 	for ((i) = (fq)->head; (i) != (fq)->tail; (i) = ((i) + 1) % IOVA_FQ_SIZE)
-- 
2.11.0
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v11 01/12] iova: Export alloc_iova_fast() and free_iova_fast()

From: Will Deacon <will@kernel.org>
Date: 2021-08-25 09:55:51

On Tue, Aug 24, 2021 at 02:08:33PM -0400, Michael S. Tsirkin wrote:
On Wed, Aug 18, 2021 at 08:06:31PM +0800, Xie Yongji wrote:
quoted
Export alloc_iova_fast() and free_iova_fast() so that
some modules can make use of the per-CPU cache to get
rid of rbtree spinlock in alloc_iova() and free_iova()
during IOVA allocation.

Signed-off-by: Xie Yongji <redacted>

This needs ack from iommu maintainers. Guys?
Looks fine to me:

Acked-by: Will Deacon <will@kernel.org>

Will
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help