# Re: \[PATCH v2 4/4\] bus: Make remove callback return void

- From: Dan Williams \<hidden\>
- Date: 2021-07-06 18:51:31 
- List: virtualization
- Page: https://ratatoskr.run/virtualization/2021/07/1434959
- Thread: https://ratatoskr.run/linux-mips/2021/07/1434856/t.md

```text
On Tue, Jul 6, 2021 at 8:51 AM Uwe Kleine-König
[ref] wrote:
>
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
>
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
>
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
>

>  drivers/cxl/core.c                        | 3 +--
>  drivers/dax/bus.c                         | 4 +---
>  drivers/nvdimm/bus.c                      | 3 +--

For CXL, DAX, and NVDIMM

Acked-by: Dan Williams <redacted>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
```