# Re: \[PATCH v10\] i2c: virtio: add a virtio i2c frontend driver

- From: Viresh Kumar \<viresh.kumar@linaro.org\>
- Date: 2021-06-30 15:09:13 
- List: virtualization
- Page: https://ratatoskr.run/virtualization/2021/06/1430048
- Thread: https://ratatoskr.run/linux-i2c/2021/03/6311697/t.md

```text
On 30-06-21, 16:38, Wolfram Sang wrote:
> > While we are at it, this has been replaced by a Rust counterpart [1]
> > (as that makes it hypervisor agnostic, which is the goal of my work
> > here) and I need someone with I2C knowledge to help review it. It
> > should be okay even if you don't understand Rust a lot, just review
> > this file[2] which is where most of i2c specific stuff lies.
> 
> From the high level review I can provide, it looks good to me. Block
> transfers are missing, but I think you said that already. Mising Rust
> experience, I might miss details, of course. But the general approach
> seems fine to me. smbus_prepare() will get a bit more messy when you add
> block transfers, but it still looks bearable, I think.

Thanks for having a look.

-- 
viresh
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
```