# Re: \[PATCH\] vp\_vdpa: correct the return value when fail to map notification

- From: Stefano Garzarella \<sgarzare@redhat.com\>
- Date: 2021-06-28 15:33:05 
- List: virtualization
- Page: https://ratatoskr.run/virtualization/2021/06/1428187
- Thread: https://ratatoskr.run/lkml/2021/06/1424413/t.md

```text
On Thu, Jun 24, 2021 at 11:59:39AM +0800, Jason Wang wrote:
>We forget to assign a error value when we fail to map the notification
>during prove. This patch fixes it.
>
>Reported-by: kernel test robot <redacted>
>Reported-by: Dan Carpenter <redacted>
>Fixes: 11d8ffed00b23 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
>Signed-off-by: Jason Wang <redacted>
>---
> drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
>index c76ebb531212..9145e0624565 100644
>--- a/drivers/vdpa/virtio_pci/vp_vdpa.c
>+++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
>@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> 			vp_modern_map_vq_notify(mdev, i,
> 						&vp_vdpa->vring[i].notify_pa);
> 		if (!vp_vdpa->vring[i].notify) {
>+			ret = -EINVAL;
> 			dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
> 			goto err;
> 		}
>-- 
>2.25.1

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
```
