# Re: \[PATCH\] vringh: Use wiov-\>used to check for read/write desc order

- From: Jason Wang \<hidden\>
- Date: 2021-06-23 03:21:46 
- List: virtualization
- Page: https://ratatoskr.run/virtualization/2021/06/1423220
- Thread: https://ratatoskr.run/netdev/2021/06/1422349/t.md

```text

在 2021/6/22 下午7:37, Neeraj Upadhyay 写道:
> As iov->used is incremented when descriptors are processed
> in __vringh_iov(), use it to check for incorrect read
> and write descriptor order.
>
> Signed-off-by: Neeraj Upadhyay <redacted>


Acked-by: Jason Wang <redacted>


> ---
>   drivers/vhost/vringh.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
> index 4af8fa2..14e2043 100644
> --- a/drivers/vhost/vringh.c
> +++ b/drivers/vhost/vringh.c
> @@ -359,7 +359,7 @@ __vringh_iov(struct vringh *vrh, u16 i,
>   			iov = wiov;
>   		else {
>   			iov = riov;
> -			if (unlikely(wiov && wiov->i)) {
> +			if (unlikely(wiov && wiov->used)) {
>   				vringh_bad("Readable desc %p after writable",
>   					   &descs[i]);
>   				err = -EINVAL;

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
```