[PATCH 07/10] drm/qxl: fix prime kmap

Subsystems: drm driver for qxl virtual gpu, drm drivers, drm drivers and misc gpu patches, the rest

STALE2008d

2 messages, 2 authors, 2021-02-16 · open the first message on its own page

[PATCH 07/10] drm/qxl: fix prime kmap

From: Gerd Hoffmann <kraxel@redhat.com>
Date: 2021-02-16 11:40:19

Use the correct kmap variant.  We don't have a reservation here,
so we can't use the _locked version.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 drivers/gpu/drm/qxl/qxl_prime.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_prime.c b/drivers/gpu/drm/qxl/qxl_prime.c
index dc295b2e2b52..4aa949799446 100644
--- a/drivers/gpu/drm/qxl/qxl_prime.c
+++ b/drivers/gpu/drm/qxl/qxl_prime.c
@@ -59,7 +59,7 @@ int qxl_gem_prime_vmap(struct drm_gem_object *obj, struct dma_buf_map *map)
 	struct qxl_bo *bo = gem_to_qxl_bo(obj);
 	int ret;
 
-	ret = qxl_bo_kmap_locked(bo, map);
+	ret = qxl_bo_kmap(bo, map);
 	if (ret < 0)
 		return ret;
 
@@ -71,7 +71,7 @@ void qxl_gem_prime_vunmap(struct drm_gem_object *obj,
 {
 	struct qxl_bo *bo = gem_to_qxl_bo(obj);
 
-	qxl_bo_kunmap_locked(bo);
+	qxl_bo_kunmap(bo);
 }
 
 int qxl_gem_prime_mmap(struct drm_gem_object *obj,
-- 
2.29.2

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 07/10] drm/qxl: fix prime kmap

From: Thomas Zimmermann <tzimmermann@suse.de>
Date: 2021-02-16 13:17:12

Hi

Am 16.02.21 um 12:37 schrieb Gerd Hoffmann:
Use the correct kmap variant.  We don't have a reservation here,
so we can't use the _locked version.
I'd merge this change into patch 6. So the new functions come with a caller.

Best regards
Thomas
quoted hunk
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
  drivers/gpu/drm/qxl/qxl_prime.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_prime.c b/drivers/gpu/drm/qxl/qxl_prime.c
index dc295b2e2b52..4aa949799446 100644
--- a/drivers/gpu/drm/qxl/qxl_prime.c
+++ b/drivers/gpu/drm/qxl/qxl_prime.c
@@ -59,7 +59,7 @@ int qxl_gem_prime_vmap(struct drm_gem_object *obj, struct dma_buf_map *map)
  	struct qxl_bo *bo = gem_to_qxl_bo(obj);
  	int ret;
  
-	ret = qxl_bo_kmap_locked(bo, map);
+	ret = qxl_bo_kmap(bo, map);
  	if (ret < 0)
  		return ret;
  
@@ -71,7 +71,7 @@ void qxl_gem_prime_vunmap(struct drm_gem_object *obj,
  {
  	struct qxl_bo *bo = gem_to_qxl_bo(obj);
  
-	qxl_bo_kunmap_locked(bo);
+	qxl_bo_kunmap(bo);
  }
  
  int qxl_gem_prime_mmap(struct drm_gem_object *obj,
-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help