# Re: \[PATCH V2 2/2\] block: remove unnecessary argument from blk\_execute\_rq

- From: Guoqing Jiang \<hidden\>
- Date: 2021-01-25 04:37:17 
- List: virtualization
- Page: https://ratatoskr.run/virtualization/2021/01/6400460
- Thread: https://ratatoskr.run/linux-nfs/2021/01/6400407/t.md

```text


On 1/22/21 10:50, Ulf Hansson wrote:
> On Fri, 22 Jan 2021 at 10:28, Guoqing Jiang
> [ref] wrote:
>>
>> We can remove 'q' from blk_execute_rq as well after the previous change
>> in blk_execute_rq_nowait.
>>
>> And more importantly it never really was needed to start with given
>> that we can trivial derive it from struct request.
>>
>> Cc: <redacted>
>> Cc: <redacted>
>> Cc: <redacted>
>> Cc: <redacted>
>> Cc: <redacted>
>> Cc: <redacted>
>> Signed-off-by: Guoqing Jiang <redacted>
>
> [...]
>
>>   drivers/mmc/core/block.c          | 10 +++++-----
>
> [...]
>
>  From mmc point of view, please add:
>
> Acked-by: Ulf Hansson <redacted>
>
> At the moment I don't think this will conflict with any changes to
> mmc, but if that happens let's sort it then...
>

Thank you! Will resend and add your acked-by.

Guoqing
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
```
