Re: [PATCH] virtio-mem: Assign boolean values to a bool variable

7 messages, 2 authors, 2021-01-20 · open the first message on its own page

Re: [PATCH] virtio-mem: Assign boolean values to a bool variable

From: David Hildenbrand <hidden>
Date: 2021-01-20 10:25:48 

On 20.01.21 08:50, Jiapeng Zhong wrote:
quoted hunk
Fix the following coccicheck warnings:

./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
of 0/1 to bool variable.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Zhong <redacted>
---
 drivers/virtio/virtio_mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index 9fc9ec4..85a272c 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
 	 * actually in use (e.g., trying to reload the driver).
 	 */
 	if (vm->plugged_size) {
-		vm->unplug_all_required = 1;
+		vm->unplug_all_required = true;
 		dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
 	}
 
Hi,

we already had a fix on the list for quite a while:

https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com

However, looks like Michael queued your patch on the vhost tree instead.

-- 
Thanks,

David / dhildenb

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] virtio-mem: Assign boolean values to a bool variable

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2021-01-20 10:25:50 

On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote:
On 20.01.21 08:50, Jiapeng Zhong wrote:
quoted
Fix the following coccicheck warnings:

./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
of 0/1 to bool variable.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Zhong <redacted>
---
 drivers/virtio/virtio_mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index 9fc9ec4..85a272c 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
 	 * actually in use (e.g., trying to reload the driver).
 	 */
 	if (vm->plugged_size) {
-		vm->unplug_all_required = 1;
+		vm->unplug_all_required = true;
 		dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
 	}
 
Hi,

we already had a fix on the list for quite a while:

https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com
Can't find that one.

However, looks like Michael queued your patch on the vhost tree instead.

-- 
Thanks,

David / dhildenb
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] virtio-mem: Assign boolean values to a bool variable

From: David Hildenbrand <hidden>
Date: 2021-01-20 10:30:29 

On 20.01.21 10:57, Michael S. Tsirkin wrote:
On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote:
quoted
On 20.01.21 08:50, Jiapeng Zhong wrote:
quoted
Fix the following coccicheck warnings:

./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
of 0/1 to bool variable.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Zhong <redacted>
---
 drivers/virtio/virtio_mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index 9fc9ec4..85a272c 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
 	 * actually in use (e.g., trying to reload the driver).
 	 */
 	if (vm->plugged_size) {
-		vm->unplug_all_required = 1;
+		vm->unplug_all_required = true;
 		dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
 	}
 
Hi,

we already had a fix on the list for quite a while:

https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com
Can't find that one.
Looks like it was only on virtualization@ and a couple of people on cc.

https://lists.linuxfoundation.org/pipermail/virtualization/2020-December/051662.html

Interestingly, I cannot find the follow-up ("[PATCH] virtio-mem: use
boolean value when setting vm->unplug_all_required") in the mailing list
archives, even though it has virtualization@ on cc.

-- 
Thanks,

David / dhildenb

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] virtio-mem: Assign boolean values to a bool variable

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2021-01-20 11:51:41 

On Wed, Jan 20, 2021 at 11:04:18AM +0100, David Hildenbrand wrote:
On 20.01.21 10:57, Michael S. Tsirkin wrote:
quoted
On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote:
quoted
On 20.01.21 08:50, Jiapeng Zhong wrote:
quoted
Fix the following coccicheck warnings:

./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
of 0/1 to bool variable.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Zhong <redacted>
---
 drivers/virtio/virtio_mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index 9fc9ec4..85a272c 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
 	 * actually in use (e.g., trying to reload the driver).
 	 */
 	if (vm->plugged_size) {
-		vm->unplug_all_required = 1;
+		vm->unplug_all_required = true;
 		dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
 	}
 
Hi,

we already had a fix on the list for quite a while:

https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com
Can't find that one.
Looks like it was only on virtualization@ and a couple of people on cc.

https://lists.linuxfoundation.org/pipermail/virtualization/2020-December/051662.html

Interestingly, I cannot find the follow-up ("[PATCH] virtio-mem: use
boolean value when setting vm->unplug_all_required") in the mailing list
archives, even though it has virtualization@ on cc.

Unsurprising that I didn't merge it then ;)
Want to send your ack on this one?

-- 
Thanks,

David / dhildenb
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] virtio-mem: Assign boolean values to a bool variable

From: David Hildenbrand <hidden>
Date: 2021-01-20 12:00:12 

On 20.01.21 12:03, Michael S. Tsirkin wrote:
On Wed, Jan 20, 2021 at 11:04:18AM +0100, David Hildenbrand wrote:
quoted
On 20.01.21 10:57, Michael S. Tsirkin wrote:
quoted
On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote:
quoted
On 20.01.21 08:50, Jiapeng Zhong wrote:
quoted
Fix the following coccicheck warnings:

./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
of 0/1 to bool variable.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Zhong <redacted>
---
 drivers/virtio/virtio_mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index 9fc9ec4..85a272c 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
 	 * actually in use (e.g., trying to reload the driver).
 	 */
 	if (vm->plugged_size) {
-		vm->unplug_all_required = 1;
+		vm->unplug_all_required = true;
 		dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
 	}
 
Hi,

we already had a fix on the list for quite a while:

https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com
Can't find that one.
Looks like it was only on virtualization@ and a couple of people on cc.

https://lists.linuxfoundation.org/pipermail/virtualization/2020-December/051662.html

Interestingly, I cannot find the follow-up ("[PATCH] virtio-mem: use
boolean value when setting vm->unplug_all_required") in the mailing list
archives, even though it has virtualization@ on cc.

Unsurprising that I didn't merge it then ;)
Well, you were on cc ;)

Want to send your ack on this one?
Sure

Acked-by: David Hildenbrand <redacted>


-- 
Thanks,

David / dhildenb

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] virtio-mem: Assign boolean values to a bool variable

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2021-01-20 12:00:25 

On Wed, Jan 20, 2021 at 12:14:14PM +0100, David Hildenbrand wrote:
On 20.01.21 12:03, Michael S. Tsirkin wrote:
quoted
On Wed, Jan 20, 2021 at 11:04:18AM +0100, David Hildenbrand wrote:
quoted
On 20.01.21 10:57, Michael S. Tsirkin wrote:
quoted
On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote:
quoted
On 20.01.21 08:50, Jiapeng Zhong wrote:
quoted
Fix the following coccicheck warnings:

./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
of 0/1 to bool variable.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Zhong <redacted>
---
 drivers/virtio/virtio_mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index 9fc9ec4..85a272c 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
 	 * actually in use (e.g., trying to reload the driver).
 	 */
 	if (vm->plugged_size) {
-		vm->unplug_all_required = 1;
+		vm->unplug_all_required = true;
 		dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
 	}
 
Hi,

we already had a fix on the list for quite a while:

https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com
Can't find that one.
Looks like it was only on virtualization@ and a couple of people on cc.

https://lists.linuxfoundation.org/pipermail/virtualization/2020-December/051662.html

Interestingly, I cannot find the follow-up ("[PATCH] virtio-mem: use
boolean value when setting vm->unplug_all_required") in the mailing list
archives, even though it has virtualization@ on cc.

Unsurprising that I didn't merge it then ;)
Well, you were on cc ;)
Hmm true. Found it now.
quoted
Want to send your ack on this one?
Sure

Acked-by: David Hildenbrand <redacted>

Added yours and the original Signed-off-by.

Thanks!

-- 
Thanks,

David / dhildenb
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] virtio-mem: Assign boolean values to a bool variable

From: David Hildenbrand <hidden>
Date: 2021-01-20 12:00:25

quoted
quoted
Want to send your ack on this one?
Sure

Acked-by: David Hildenbrand <redacted>

Added yours and the original Signed-off-by.

Thanks!
Thanks Michael!


-- 
Thanks,

David / dhildenb

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help