[PATCH] virtio-mem: drop unnecessary initialization

Subsystems: the rest, virtio core, virtio mem driver

STALE2288d

4 messages, 4 authors, 2020-06-09 · open the first message on its own page

[PATCH] virtio-mem: drop unnecessary initialization

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2020-06-08 05:45:35 

rc is initialized to -ENIVAL but that's never used. Drop it.

Fixes: 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug")
Reported-by: kernel test robot <redacted>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 drivers/virtio/virtio_mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index f658fe9149be..2f357142ea5e 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -1768,7 +1768,7 @@ static void virtio_mem_delete_resource(struct virtio_mem *vm)
 static int virtio_mem_probe(struct virtio_device *vdev)
 {
 	struct virtio_mem *vm;
-	int rc = -EINVAL;
+	int rc;
 
 	BUILD_BUG_ON(sizeof(struct virtio_mem_req) != 24);
 	BUILD_BUG_ON(sizeof(struct virtio_mem_resp) != 10);
-- 
MST

Re: [PATCH] virtio-mem: drop unnecessary initialization

From: Jason Wang <hidden>
Date: 2020-06-08 06:00:38 

On 2020/6/8 下午1:45, Michael S. Tsirkin wrote:
quoted hunk
rc is initialized to -ENIVAL but that's never used. Drop it.

Fixes: 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug")
Reported-by: kernel test robot <redacted>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
  drivers/virtio/virtio_mem.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index f658fe9149be..2f357142ea5e 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -1768,7 +1768,7 @@ static void virtio_mem_delete_resource(struct virtio_mem *vm)
  static int virtio_mem_probe(struct virtio_device *vdev)
  {
  	struct virtio_mem *vm;
-	int rc = -EINVAL;
+	int rc;
  
  	BUILD_BUG_ON(sizeof(struct virtio_mem_req) != 24);
  	BUILD_BUG_ON(sizeof(struct virtio_mem_resp) != 10);

Acked-by: Jason Wang <redacted>


_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] virtio-mem: drop unnecessary initialization

From: David Hildenbrand <hidden>
Date: 2020-06-08 06:44:44 

On 08.06.20 07:45, Michael S. Tsirkin wrote:
quoted hunk
rc is initialized to -ENIVAL but that's never used. Drop it.

Fixes: 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug")
Reported-by: kernel test robot <redacted>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 drivers/virtio/virtio_mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index f658fe9149be..2f357142ea5e 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -1768,7 +1768,7 @@ static void virtio_mem_delete_resource(struct virtio_mem *vm)
 static int virtio_mem_probe(struct virtio_device *vdev)
 {
 	struct virtio_mem *vm;
-	int rc = -EINVAL;
+	int rc;
 
 	BUILD_BUG_ON(sizeof(struct virtio_mem_req) != 24);
 	BUILD_BUG_ON(sizeof(struct virtio_mem_resp) != 10);
Acked-by: David Hildenbrand <redacted>

-- 
Thanks,

David / dhildenb

Re: [PATCH] virtio-mem: drop unnecessary initialization

From: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Date: 2020-06-09 04:53:25

quoted hunk
rc is initialized to -ENIVAL but that's never used. Drop it.

Fixes: 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug")
Reported-by: kernel test robot <redacted>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 drivers/virtio/virtio_mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index f658fe9149be..2f357142ea5e 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -1768,7 +1768,7 @@ static void virtio_mem_delete_resource(struct virtio_mem *vm)
 static int virtio_mem_probe(struct virtio_device *vdev)
 {
        struct virtio_mem *vm;
-       int rc = -EINVAL;
+       int rc;

        BUILD_BUG_ON(sizeof(struct virtio_mem_req) != 24);
        BUILD_BUG_ON(sizeof(struct virtio_mem_resp) != 10);
Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help