Thread (152 messages) 152 messages, 8 authors, 2020-06-12

Re: [PATCH v3 35/75] x86/head/64: Build k/head64.c with -fno-stack-protector

From: Borislav Petkov <bp@alien8.de>
Date: 2020-05-19 09:15:37
Also in: kvm, lkml

On Tue, Apr 28, 2020 at 05:16:45PM +0200, Joerg Roedel wrote:
From: Joerg Roedel <redacted>

The code inserted by the stack protector does not work in the early
boot environment because it uses the GS segment, at least with memory
encryption enabled.
Can you elaborate on why is that a problem?

The stack cookie is not generated that early yet so it should be
comparing %gs:40 to 0.

Also, it generates the checking code here only with

CONFIG_STACKPROTECTOR_STRONG=y
Make sure the early code is compiled without this feature enabled.
If so, then this should be with CONFIG_AMD_MEM_ENCRYPT ifdeffery around
it.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help