# Re: \[PATCH v6 3/3\] x86: paravirt: make native\_save\_fl extern inline

- From: Ingo Molnar \<mingo@kernel.org\>
- Date: 2018-06-22 02:24:11 
- List: virtualization
- Page: https://ratatoskr.run/virtualization/2018/06/5314156
- Thread: https://ratatoskr.run/linux-efi/2018/06/5313737/t.md

```text

* Nick Desaulniers [ref] wrote:

> native_save_fl() is marked static inline, but by using it as
> a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined.

> --- a/arch/x86/include/asm/irqflags.h
> +++ b/arch/x86/include/asm/irqflags.h
> @@ -13,7 +13,7 @@
>   * Interrupt control:
>   */
>  
> -static inline unsigned long native_save_fl(void)
> +extern inline unsigned long native_save_fl(void)
>  {
>  	unsigned long flags;
>  

What's the code generation effect of this on say a defconfig kernel vmlinux with 
paravirt enabled?

Thanks,

	Ingo
```