# Re: \[PATCH 1/5\] virtio-gpu: add virtio\_gpu\_queue\_ctrl\_buffer\_nolock

- From: Gerd Hoffmann \<kraxel@redhat.com\>
- Date: 2015-09-10 14:04:55 
- List: virtualization
- Page: https://ratatoskr.run/virtualization/2015/09/4573043
- Thread: https://ratatoskr.run/dri-devel/2015/09/9086396/t.md

```text
On Do, 2015-09-10 at 09:39 +0100, Emil Velikov wrote:
> Hi Gerd,
> 
> On 9 September 2015 at 12:42, Gerd Hoffmann [ref] wrote:
> > Add virtio_gpu_queue_ctrl_buffer_nolock function, which does the same as
> > virtio_gpu_queue_ctrl_buffer but does not take the virtqueue lock.  The
> > caller must hold the lock instead.
> >
> The drm subsystem tends to use *_locked and *_unlocked suffixes. With
> the latter being less common.
> Not a big deal but perhaps you can use one of those for virtio ?

_locked looks correct for this case to me (looking at drm_vm_close +
drm_vm_close_locked to compare).  I'll change it.

cheers,
  Gerd
```
